Skip to content

Split assertion for ionic module loading

Kristian Gregorius Hustad requested to merge kghustad/external-imp-fixes into master

What does this MR do?

@lenam ran into an issue where external IMPs weren't loaded because openCARP had been built with -CMAKE_BUILD_TYPE=RelWithDebInfo, meaning that -DNDEBUG was passed as a compiler flag. The external IMPs are loaded in an assertion (checking that the loading succeeded), but the loading needs to happen outside the assert() call, so that the assert() call and the evaluation of its arguments can safely be omitted.

This MR ensures that external ionic modules are loaded even when -DNDEBUG is passed as a compiler flag (and the assert() line is removed in the preprocessing step).

Author's checklist

  • Follow the Contribution Guidelines.
  • Describe your change in the CHANGELOG.md file in the top-level folder of the openCARP repository.
  • Apply the appropriate labels.

Reviewer's checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Contribution Guidelines.

Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

Maintainer

  • Review by assigned maintainer, who can always request/require the above reviews.
  • Ensure a release milestone is set.

Merge request reports