Skip to content

fix: correction of unit conversion & refactoring

Moritz Linder requested to merge 356-stim-assign into master

What does this MR do?

Fixed unit conversion of transmembrane charge into concentration and refactoring: from stim_curr = curr*beta/FARADAY/z*1.e-2 to delta_conc = charge*beta/FARADAY/z*1.e-1

Related issues

356-stim-assign

Author's checklist

  • Follow the Contribution Guidelines. Sign the CLA and add yourself to the list of contribtutors for your first contribution.
  • Describe your change in the CHANGELOG.md file in the top-level folder of the openCARP repository.
  • Apply the appropriate labels.
  • Does this commit add new dependencies? If no, just tick the box. If yes, please evaluate carefully if the additional dependency is a more sustainable option than including the functionality in own code. If the former, describe the dependency clearly, add them to the Software Management Plan and the installation instructions (*.md files, CMake files, Docker files etc.).

Reviewer's checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Contribution Guidelines.

Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

Maintainer

  • Review by assigned maintainer, who can always request/require the above reviews.
Edited by Moritz Linder

Merge request reports