Skip to content

Fix ion get sv offset

Atoli Huppe requested to merge fix-get-sv-offset into master

What does this MR do?

Fix a bug in the MLIR+DLO build where sv_dump would output too many values. For a example with a vector size 8, the value for each state variable would be dumped 8 times instead of just once per time step.

This bug was caused by the ambiguous get_sv_offset when manipulating structure of arrays. Now get_sv_offset will always return the size of the underlying type of the state variable (float/double) instead of the size of the array (float[8]/double[8]). This makes things more uniform with the standard build.

Related issues

Author's checklist

  • Follow the Contribution Guidelines. Sign the CLA and add yourself to the list of contribtutors for your first contribution.
  • Describe your change in the CHANGELOG.md file in the top-level folder of the openCARP repository.
  • Apply the appropriate labels.
  • Does this commit add new dependencies? If no, just tick the box. If yes, please evaluate carefully if the additional dependency is a more sustainable option than including the functionality in own code. If the former, describe the dependency clearly, add them to the Software Management Plan and the installation instructions (*.md files, CMake files, Docker files etc.).

Reviewer's checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Contribution Guidelines.

Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

Maintainer

  • Review by assigned maintainer, who can always request/require the above reviews.

Merge request reports