Skip to content

Bugfixes and updated descriptions in Examples 03A and 03E

Tobias Gerach requested to merge bugfix_examples into master

What does this MR do?

Example 03A:

  • Added a small hint to press ENTER when the run seems to get stuck (happens because the results directory already exists and the clean.override_check() in the decorator function is not triggered until you press ENTER in terminal).

Example 03E (Niederer benchmark):

  • Fixed state variable file in Niederer benchmark problem. State vars were incomplete and out of order
  • Fixed a bug that resulted in the svars not being read from file + removed unused params and funcs
  • Added a description and images for the example (did not check the html output yet)

Regression Test:

  • Added regression tests for full mass matrix and lumped mass matrix using the Niederer et al. benchmark setup
  • Added updated reference solutions for the new test cases
  • Added autotester configuration for monodomain regression tests. Currently running in the openCARP-Bidomain group but physically separated from the bidomain tests. The atc_template_monodomain.py replaces the old act_template_niederer_benchmark.py and generalizes the configuration of monodomain regression tests found in devtests/monodomain.

Related issues

None

Author's checklist

  • Follow the Contribution Guidelines.
  • Apply the appropriate labels.
  • Does this commit add new dependencies (e.g. Python modules)? If yes, please evaluate carefully if the additional dependency is a more sustainable option than including the functionality in own code. If the former, describe the dependency clearly, add them to the Software Management Plan and the installation instructions (*.md files, CMake files, Docker files etc.).

Reviewer's checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Contribution Guidelines.

Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

Maintainer

  • Review by assigned maintainer, who can always request/require the above reviews.
  • Ensure a release milestone is set.
Edited by Gunnar Seemann

Merge request reports