Skip to content

Disable openMP in meshtool if disabled in openCARP

Marie Houillon requested to merge bump_meshtool into master

What does this MR do?

Problem solved: When building openCARP and external tools (including meshtool) with cmake, openMP is enabled in meshtool even if the option USE_OPENMP is not set to True. As a consequence, it leads to an error during meshtool compilation if openMP is not available on the system (typically on MacOS).

This merge request:

  • Updates the version of meshtool included when building openCARP with external tools (it fixes some openMP includes in meshtool when openMP is disabled)
  • Disables openMP for meshtool if it is disabled for openCARP.

@aneic Do you see a better way than this to disable openMP when compiling meshtool?

Related issues

https://opencarp.org/q2a/624/error-during-installation-on-macos

Author's checklist

  • Follow the Contribution Guidelines.
  • Describe your change in the CHANGELOG.md file in the top-level folder of the openCARP repository.
  • Apply the appropriate labels.
  • Does this commit add new dependencies? If no, just tick the box. If yes, please evaluate carefully if the additional dependency is a more sustainable option than including the functionality in own code. If the former, describe the dependency clearly, add them to the Software Management Plan and the installation instructions (*.md files, CMake files, Docker files etc.).

Reviewer's checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Contribution Guidelines.

Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

Maintainer

  • Review by assigned maintainer, who can always request/require the above reviews.

Merge request reports