limpet folder name and paths in model/generate.py
Summary
I tried to use the carputils Makefile
, but I encountered an error when runnning make models
, due to the use of relative paths.
When running the generate.py script with a relative, path, I obtain the following error:
Error: Can't open ../../../../physics/limpet/models/imp_list.txt! Perhaps you should use the full path name to the file?
What version of carputils and/or openCARP are you using?
Commits: carputils: 36d11694 openCARP: 9f86c0a13b7553f6aea55e714fe769964586b704
Steps to reproduce
With carputils installed in ${openCARP}/external/, change directory to ${carputils}/carputils/model/
,
then run
./generate.py ../../../..
What is the current bug behavior?
I obtain the following error:
Error: Can't open ../../../../physics/limpet/models/imp_list.txt! Perhaps you should use the full path name to the file?
What is the expected correct behavior?
The path is correctly handled, the file is found and no error is obtained.
Possible fixes
I changed the path given as a command line argument to generate.py
to an absolute path in this branch:
fc9334ab
This issue is also there to ask for feedback for another change that I made in this commit:
The limpet folder in openCARP is spelled as physics/LIMPET
in generate.py
. Shouldn't it be physics/limpet
?
Thanks in advance for any feedback, Marie